Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: eval?.() is indirect #11850

Merged
merged 1 commit into from Jul 20, 2020
Merged

fix: eval?.() is indirect #11850

merged 1 commit into from Jul 20, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 20, 2020 •
edited by gitpod-io bot

Q                       A
Fixed Issues? babel/proposals#67 (comment)
Patch: Bug Fix? Yes
License MIT

Transform eval?.() as (0,eval)() when eval is not nullish.

@JLHwung JLHwung added PR: Spec Compliance 👓 A type of pull request used for our changelog categories Spec: Optional Chaining labels Jul 20, 2020
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26108/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 239928f:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung JLHwung merged commit e51a91e into babel:main Jul 20, 2020
@JLHwung JLHwung deleted the optional-eval-is-indirect branch July 20, 2020 21:06
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 20, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@jridgewell jridgewell jridgewell approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Spec Compliance 👓 A type of pull request used for our changelog categories Spec: Optional Chaining
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JLHwung @babel-bot @existentialism @jridgewell @nicolo-ribaudo