Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow 09.1_1 and 09e1_1 in sloppy mode #11854

Merged
merged 3 commits into from Jul 21, 2020
Merged

fix: allow 09.1_1 and 09e1_1 in sloppy mode #11854

merged 3 commits into from Jul 21, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 20, 2020 •
edited by gitpod-io bot

Q                       A
Fixed Issues? babel/proposals#67 (comment)
Patch: Bug Fix? Y
License MIT

Fixed by moving codes. Also simplified boolean states a bit.

@JLHwung JLHwung added PR: Spec Compliance 👓 A type of pull request used for our changelog categories pkg: parser labels Jul 20, 2020
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 20, 2020 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26160/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 20, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6cd4578:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung JLHwung merged commit 3680f01 into babel:main Jul 21, 2020
@JLHwung JLHwung deleted the allow-_-in-fe-non-octal-decimal branch July 21, 2020 13:44
fisker added a commit to fisker/prettier that referenced this pull request Aug 1, 2020
@fisker
Test babel 11854
ea62a93 
babel/babel#11854
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Spec Compliance 👓 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JLHwung @babel-bot @existentialism @nicolo-ribaudo