Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable numericSeparator parsing support #11863

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 21, 2020

Q                       A
Minor: New Feature? Yes
Tests Added + Pass? Yes
License MIT

This PR enables numericSeparator parsing support in @babel/parser.

Note that this PR targets to a feature branch feat-7.11.0/stage-4, it can be merged if we can have two approval.

@JLHwung JLHwung added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: parser labels Jul 21, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2fec8fe:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung JLHwung mentioned this pull request Jul 21, 2020
5 tasks
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26257/

@nicolo-ribaudo nicolo-ribaudo merged commit 475c397 into babel:feat-7.11.0/stage-4 Jul 22, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the enable-numeric-separator-parsing branch July 22, 2020 08:47
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 22, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants