Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add numeric-separator to preset-env #11865

Merged
merged 2 commits into from Jul 22, 2020
Merged

Add numeric-separator to preset-env #11865

merged 2 commits into from Jul 22, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 21, 2020 •
edited by gitpod-io bot

Q                       A
Minor: New Feature? Yes
Tests Added + Pass? Yes
License MIT

numeric-separator was added to preset-env in #10971 but behind shippedProposals flag. This PR moves the proposal to es2021 feature sets.

@JLHwung JLHwung added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: preset-env labels Jul 21, 2020
@JLHwung JLHwung mentioned this pull request Jul 21, 2020
Merged
5 tasks
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26274/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e3b41da:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo added this to the 7.11.0 milestone Jul 22, 2020
@nicolo-ribaudo nicolo-ribaudo added PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release and removed PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release labels Jul 22, 2020
@nicolo-ribaudo
Copy link
Member

Oh I didn't notice the feature branch

@nicolo-ribaudo nicolo-ribaudo merged commit 8f3f175 into babel:feat-7.11.0/stage-4 Jul 22, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the numeric-separator-preset-env branch July 22, 2020 08:46
JLHwung added a commit that referenced this pull request Jul 29, 2020
@JLHwung
Add numeric-separator to preset-env (#11865)
ccd98f0
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 22, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: New Feature 🚀 A type of pull request used for our changelog categories
Projects
None yet
Milestone
7.11.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JLHwung @babel-bot @nicolo-ribaudo @existentialism