New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable logical assignment in babel preset env #11876
Conversation
morrme
commented
Jul 26, 2020
•
edited by gitpod-io
bot
edited by gitpod-io
bot
Q | A |
---|---|
Fixed Issues? | Fixes #11861 |
Patch: Bug Fix? | No |
Major: Breaking Change? | No |
Minor: New Feature? | No |
Tests Added + Pass? | Yes |
Documentation PR Link | n/a |
Any Dependency Changes? | No |
License | MIT |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dcc17b4:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the test fixtures?
You can run
OVERWRITE=true yarn jest
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26513/ |
@@ -21,6 +21,7 @@ | |||
"samsung": "11", | |||
"electron": "6" | |||
}, | |||
"proposal-logical-assignment-operators": {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note (not in this PR): we probably need to update compat-table
@morrme thanks! |
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>