Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect module path when absoluteRuntime is specified #11893

Merged
merged 5 commits into from Jul 30, 2020
Merged

Fix incorrect module path when absoluteRuntime is specified #11893

merged 5 commits into from Jul 30, 2020

Conversation

sz-coder
Copy link
Contributor

@sz-coder sz-coder commented Jul 29, 2020 •
edited by gitpod-io bot

Q                       A
Fixed Issues? Fixes #11885
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT

Changed moduleName to modulePath in packages/plugin-transform-runtime/src/index.js.

JLHwung
JLHwung approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Looks good to me with some nits.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 29, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 433c55d:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung JLHwung added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Jul 29, 2020
@JLHwung JLHwung changed the title Fix issue 11885 Fix incorrect module path when absoluteRuntime is specified Jul 29, 2020
@sz-coder
Copy link
Contributor Author

sz-coder commented Jul 29, 2020 •
edited

Do I have to change anything or are these changes applied automatically?

Sorry I'm not familiar with GitHub Pull Requests.

@JLHwung
Copy link
Contributor

JLHwung commented Jul 29, 2020

@sz-coder They can be applied from GUI, however we still have to manually update the test fixtures:

OVERWRITE=true yarn jest transform-runtime

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 29, 2020 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26646/

JLHwung
JLHwung reviewed Jul 30, 2020
View reviewed changes
packages/babel-plugin-transform-runtime/package.json
@@ -35,6 +35,7 @@
"@babel/plugin-transform-typeof-symbol": "^7.10.4",
"@babel/preset-env": "^7.10.4",
"@babel/runtime": "^7.10.5",
"@babel/runtime-corejs3": "^7.10.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant to fix the e2e error: https://app.circleci.com/pipelines/github/babel/babel/3524/workflows/90153e91-f615-4930-8a0f-5ed243d3a6cc/jobs/26605/parallel-runs/0/steps/0-103

The error is thrown because @babel/runtime-corejs3 is not hoisted to the top level in e2e-test. The other test is passing because @babel/runtime-corejs3 is hoisted to the top level from fixture locations, this is not guaranteed and dev deps should be declared.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JLHwung JLHwung merged commit 4ce1b70 into babel:main Jul 30, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 30, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@existentialism existentialism existentialism approved these changes

@hzoo hzoo hzoo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[@babel/plugin-transform-runtime] Option absoluteRuntime not working as expected
5 participants
@sz-coder @JLHwung @babel-bot @existentialism @hzoo