Prepare to publish @babel/eslint-* packages
#11894
Conversation
JLHwung
added
PR: Internal 🏠
| @@ -15,12 +14,17 @@ | |||
| }, | |||
| "homepage": "https://babeljs.io/", | |||
| "engines": { | |||
| "node": ">=10.9" | |||
| "node": "^10.13.0 || ^12.13.0 || >=14.0.0" | |||
There was a problem hiding this comment.
I feel like we can enforce the same ranges for Babel 8: that we don't have to fight against early node v13 versions that may complain about incorrect exports usage.
This reverts commit 5ca8acd. # Conflicts: # Makefile # eslint/babel-eslint-parser/package.json # eslint/babel-eslint-plugin-development/package.json # lerna.json # scripts/integration-tests/publish-local.sh
| @@ -18,15 +18,12 @@ | |||
| "author": "Kai Cataldo <kai@kaicataldo.com>", | |||
| "license": "MIT", | |||
| "private": true, | |||
| "engines": { | |||
There was a problem hiding this comment.
I removed the engines requirement here because its requirement can be implied from its peerDeps: @babel/eslint-parser.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b708c43:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26613/ |
| @@ -23,7 +23,7 @@ | |||
| "./package.json": "./package.json" | |||
| }, | |||
| "peerDependencies": { | |||
| "@babel/core": ">=7.11.0", | |||
| "@babel/core": ">=7.10.0", | |||
There was a problem hiding this comment.
Why do we need to change this back to 7.10.0?
There was a problem hiding this comment.
There was a problem hiding this comment.
Gotcha! So will we bump this when we do the 7.11.0 release?
There was a problem hiding this comment.
I think we still support 7.10? Maybe we should remove runtime peerDependencies checks, they should be addressed when installing packages.
|
Oops, reviewed this after it was merged |
github-actions
bot
added
the
outdated
noderequirements of@babel/eslint-*packages.This PR includes preparations need to publish
@babel/eslint-*packages. It includes commits in #11857, I will rebase once that PR gets merged.Some noticeable changes compared to #11857:
nodeto be^10.13.0 || ^12.13.0 || >=14.0.0. It covers only supported node versions as of July 2020babelto be>=7.11.0since it is the Babel version that these packages are tested againstNote that
@babel/eslint-shared-fixturesand@babel/eslint-testsare still private packages. I can not think of any use case of them and they looks to me more like a side-effect of sharing internal utils across different packages in a monorepo.