New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: hardcode @babel/eslint-parser min supported version check #11896
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7d5e539:
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26725/ |
ff94438
to
6d3cf3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can bump package.json
of @babel/eslint-parser
to >=7.11.0
again.
|
||
function baseParse(code, options) { | ||
if (typeof isRunningSupportedVersion !== "boolean") { | ||
isRunningSupportedVersion = semver.satisfies( | ||
const minSupportedCoreVersion = ">=7.0.0"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so parse was added first in 7.0? (either way 7 seems good)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@babel/core#parse()
was added in 7.0.0-beta.51
, but we need to bump this to 7.2.0
so that we have access to @babel/parser#tokTypes
.
3352d50
to
96ae45e
Compare
Thanks for reviewing this so fast! |
The original intent of this was to ensure that we're using a version of
@babel/core
that has theparse()
API. The current implementation leads to peer dependency changes causing breaking changes.Ideally, we'd like users to use the same version of
@babel/core
and@babel/eslint-parser
to ensure compatibility, but we can figure out if we want to do anything about that (logging a message, etc.) later.