Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: hardcode @babel/eslint-parser min supported version check #11896

Merged
merged 4 commits into from Jul 30, 2020

Conversation

kaicataldo
Copy link
Member

@kaicataldo kaicataldo commented Jul 30, 2020

Q                       A
Fixed Issues?
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

The original intent of this was to ensure that we're using a version of @babel/core that has the parse() API. The current implementation leads to peer dependency changes causing breaking changes.

Ideally, we'd like users to use the same version of @babel/core and @babel/eslint-parser to ensure compatibility, but we can figure out if we want to do anything about that (logging a message, etc.) later.

@kaicataldo kaicataldo added area: eslint PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Jul 30, 2020
@kaicataldo kaicataldo requested a review from JLHwung July 30, 2020 19:13
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 30, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7d5e539:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 30, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26725/

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can bump package.json of @babel/eslint-parser to >=7.11.0 again.


function baseParse(code, options) {
if (typeof isRunningSupportedVersion !== "boolean") {
isRunningSupportedVersion = semver.satisfies(
const minSupportedCoreVersion = ">=7.0.0";
Copy link
Member

@hzoo hzoo Jul 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so parse was added first in 7.0? (either way 7 seems good)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh whoops, I was looking at this. Actual PR is here. Will update!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@babel/core#parse() was added in 7.0.0-beta.51, but we need to bump this to 7.2.0 so that we have access to @babel/parser#tokTypes.

@kaicataldo kaicataldo changed the title update: change babel-eslint-parser version mismatch error to log update: hardcode @babel/eslint-parser min supported version check Jul 30, 2020
@existentialism
Copy link
Member

:shipit:

@JLHwung JLHwung merged commit f7ec170 into babel:main Jul 30, 2020
@kaicataldo kaicataldo deleted the babel-eslint-version-match branch July 30, 2020 19:46
@kaicataldo
Copy link
Member Author

Thanks for reviewing this so fast!

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 30, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: eslint outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants