Update @babel/* deps
#11899
Merged
Update @babel/* deps
#11899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
the
PR: Internal 🏠
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c3af30a:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26775/ |
existentialism
approved these changes
Jul 31, 2020
JLHwung
force-pushed
the
use-published-version-eslint-parser
branch
from
a41d317
to
c3af30a
Compare
hzoo
approved these changes
Jul 31, 2020
hzoo
reviewed
Jul 31, 2020
| @@ -105,8 +105,6 @@ module.exports = function (api) { | |||
| // TODO: Use @babel/preset-flow when | |||
| // https://github.com/babel/babel/issues/7233 is fixed | |||
| "@babel/plugin-transform-flow-strip-types", | |||
| ["@babel/proposal-class-properties", { loose: true }], | |||
kaicataldo
reviewed
Jul 31, 2020
| @@ -252,8 +252,6 @@ endif | |||
| bootstrap-only: lerna-bootstrap | |||
|
|
|||
| yarn-install: clean-all | |||
| # Install dependencies in individual packages so that we can link them at the top level. | |||
| for package in eslint/*/; do yarn --ignore-engines --cwd $$package; done | |||
There was a problem hiding this comment.
Don't we still need this until Babel 8?
There was a problem hiding this comment.
Running yarn install in sub folders incurs changes to the yarn lock files after lerna version, lerna will abort publishing with uncommitted changes. See also the PR descriptions.
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@babel/*is updatedIn this PR we also removes extra install step for
@babel/eslint-*.We have run into issues during publish: Let's say we want to publish 7.12. After
lerna version, runningyarn installwill request unpublished 7.12@babel/*deps from eslint packages, although we can choose the published version 7.11 resolved as 7.12, it will incur changes onyarn.lockand thus the publish will fail because uncommitted yarn.lock file. See https://app.circleci.com/pipelines/github/babel/babel/3558/workflows/05ae840c-67c4-4312-9776-51f33f445325/jobs/26769 for the reproducing publish error.I have replaced two eslint packages from
link:to published version. Lerna should handle them properly. Two private eslint packages are reserved as link. It happens to work because they don't have dependencies.Also simplified babel config by removing included plugins.