rescan gt/lt token after TsAsExpression is parsed #11912
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing mixture of BinaryExpression and TsAsExpression, e.g.
The
<=
is read when we are parsing TsTypeboolean
, thus it is read as a single<
(tt.relational) token instead of a compound of<=
. Here we introduce areScan_lt_gt
method and re-scan<
/>
so<=
can be correctly tokenized. Note that the TypeScript compiler adopted the same approach here:https://github.com/microsoft/TypeScript/blob/624736418132374a6213bd4c66310017ee17d38a/src/compiler/parser.ts#L4329
This PR also fixes the following issue
because
??
is read as a pair of?
questional instead of nullishCoalescing. Since it is used in Flow exclusively (#8115), I moved the code path to the flow plugin.