Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ConditionalExpressions in dry-error-messages rule #11917

Merged
merged 2 commits into from Aug 5, 2020
Merged

Support ConditionalExpressions in dry-error-messages rule #11917

merged 2 commits into from Aug 5, 2020

Conversation

existentialism
Copy link
Member

@existentialism existentialism commented Aug 5, 2020 •
edited by gitpod-io bot

Q                       A
License MIT

@existentialism existentialism added the PR: Internal 🏠 A type of pull request used for our changelog categories label Aug 5, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 5, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bf958cd:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Aug 5, 2020 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26902/

nicolo-ribaudo
nicolo-ribaudo reviewed Aug 5, 2020
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

kaicataldo
kaicataldo requested changes Aug 5, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Mind adding some tests?

I didn't do this originally because it felt brittle, but maybe we could enforce that the argument must either be a reference or a conditional where both the truths and falsy expressions are references to the imported error constant?

@kaicataldo
Copy link
Member

Sorry, wasn't clear - the suggestion to enforce what is allowed doesn't have to be a blocker for this! Just a thought I had. Ideally, someone new to the project would be able to come in and the linter would teach them exactly what we're expecting (to hopefully save reviewers from having to think about it!).

@existentialism
Copy link
Member Author

@kaicataldo added some tests

kaicataldo
kaicataldo approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@kaicataldo kaicataldo merged commit c0f6f03 into main Aug 5, 2020
@kaicataldo kaicataldo deleted the dry-ternary branch August 5, 2020 20:28
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 5, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo left review comments

@JLHwung JLHwung JLHwung approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@existentialism @babel-bot @kaicataldo @JLHwung @nicolo-ribaudo