refactor: simplify smart pipeline parsing #11919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Internal 🏠
JLHwung
commented
Aug 5, 2020
| startPos: number, | ||
| ): void { | ||
| if (this.match(tt.arrow)) { | ||
| // If the following token is invalidly `=>`, then throw a human-friendly error | ||
| // instead of something like 'Unexpected token, expected ";"'. | ||
| throw this.raise(this.state.start, Errors.PipelineBodyNoArrow); | ||
| } else if ( | ||
| pipelineStyle === "PipelineTopicExpression" && | ||
| childExpression.type === "SequenceExpression" |
There was a problem hiding this comment.
childExpression.type === "SequenceExpression" implies the fact that pipelineStyle === "PipelineTopicExpression".
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26900/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 43b6aa9:
|
nicolo-ribaudo
approved these changes
Aug 5, 2020
existentialism
approved these changes
Aug 6, 2020
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this issue when I try to add more test coverages to
@babel/parser. As you can see in https://codecov.io/gh/babel/babel/src/bc7a811fce3ceeea393229299c1cdb63858608e6/packages/babel-parser/src/parser/expression.js#L2526The
PipelineBareConstructorcase branch is not covered at all. I realized that these branches are not reachable so we can simplify the parser paths here.