Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add recoverable error on accessorIsGenerator #11921

Merged
merged 3 commits into from Aug 5, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Aug 5, 2020

Q                       A
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Add a recoverable error when accessor is generator.

@JLHwung JLHwung added PR: Polish 💅 A type of pull request used for our changelog categories pkg: parser labels Aug 5, 2020
@babel-bot
Copy link
Collaborator

babel-bot commented Aug 5, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/26934/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 5, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f9e19f3:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Brian Ng <bng412@gmail.com>
@JLHwung JLHwung merged commit cd577ee into babel:main Aug 5, 2020
@JLHwung JLHwung deleted the add-recoverable-accessor-is-generator branch August 5, 2020 21:52
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 5, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants