Simplify tokenizer update context #11944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Internal 🏠
JLHwung
commented
Aug 10, 2020
| @@ -155,7 +155,8 @@ export const types: { [name: string]: TokenType } = { | |||
| plusMin: new TokenType("+/-", { beforeExpr, binop: 9, prefix, startsExpr }), | |||
| // startsExpr: required by v8intrinsic plugin | |||
| modulo: new TokenType("%", { beforeExpr, binop: 10, startsExpr }), | |||
| star: createBinop("*", 10), | |||
| // unset `beforeExpr` as it can be `function *` | |||
| star: new TokenType("*", { binop: 10 }), | |||
There was a problem hiding this comment.
So we can remove
tt.star.updateContext = function () {
this.state.exprAllowed = false;
};because exprAllowed is always implied from beforeExpr if there isn't a customized updateContext handler.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27229/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f542129:
|
JLHwung
force-pushed
the
simplify-tokenizer-update-context
branch
from
57a3122
to
37c6a0a
Compare
nicolo-ribaudo
approved these changes
Aug 11, 2020
existentialism
approved these changes
Aug 11, 2020
JLHwung
force-pushed
the
simplify-tokenizer-update-context
branch
from
37c6a0a
to
f542129
Compare
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A side-output when working on #11941.