Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build babel-polyfill-dist on make watch #11951

Merged

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Aug 11, 2020

Q                       A
Fixed Issues? Running make watch && yarn jest object-rest-spread will throw
License MIT

As a follow-up to #11531 , this PR runs polyfill-dist task on make watch, because transform-fixture-runner requires the dist build.

@JLHwung JLHwung added area: tests PR: Internal 🏠 A type of pull request used for our changelog categories PR: Fixes failing main labels Aug 11, 2020
@babel-bot
Copy link
Collaborator

babel-bot commented Aug 11, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27268/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 11, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b4d7e7a:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung JLHwung force-pushed the build-polyfill-dist-in-make-build-no-bundle branch from 39aabeb to b4d7e7a Compare August 11, 2020 19:12
Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should figure out for ourselves how to add less to the test polyfill instead of importing the whole thing (in development with higher node version), would that be another way of dogfooding https://github.com/babel/babel-polyfills?

@JLHwung JLHwung merged commit 2e2d15f into babel:main Aug 12, 2020
@JLHwung JLHwung deleted the build-polyfill-dist-in-make-build-no-bundle branch August 12, 2020 14:18
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 12, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: tests outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Fixes failing main PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants