Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove obsolete comment #11953

Merged
merged 1 commit into from Aug 13, 2020

Conversation

jamescdavis
Copy link
Contributor

@jamescdavis jamescdavis commented Aug 11, 2020

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?
Documentation PR Link
Any Dependency Changes?
License MIT

This simply removes a comment that has become obsolete. The issue referenced in the comment is loganfsmyth/babel-plugin-transform-decorators-legacy#9 and the comment was first introduced in loganfsmyth/babel-plugin-transform-decorators-legacy@e0a1673 (referenced in the issue). The "hack" has since been reverted but the comment was not removed, thus causing confusion for anyone (at least me 😄) looking at the code (and the referenced issue is not easy to find because it's actually in an obsolete repo where this code was moved from).

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27286/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 22a2541:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit 9c565a9 into babel:main Aug 13, 2020
@jamescdavis jamescdavis deleted the remove_obsolete_comment branch August 13, 2020 11:01
@existentialism existentialism added the PR: Internal 🏠 A type of pull request used for our changelog categories label Aug 13, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants