Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not mutate newTypes #11978

Merged
merged 1 commit into from Aug 19, 2020
Merged

fix: do not mutate newTypes #11978

merged 1 commit into from Aug 19, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Aug 19, 2020 •
edited by gitpod-io bot

Q                       A
Patch: Bug Fix? Yes
License MIT

#11973 introduced a bug that newTypes may be mutated in default exports. This is unwanted.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: eslint labels Aug 19, 2020
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/27588/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c3ce0cf:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung JLHwung added this to the 7.11.4 milestone Aug 19, 2020
@JLHwung
Copy link
Contributor Author

JLHwung commented Aug 19, 2020

I am gonna merge it since it is a small fix.

@JLHwung JLHwung merged commit 1b0f19b into babel:main Aug 19, 2020
@JLHwung JLHwung deleted the do-not-mutate-new-types branch August 19, 2020 19:35
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 19, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@kaicataldo kaicataldo Awaiting requested review from kaicataldo

Assignees
No one assigned
Labels
area: eslint outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
7.11.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JLHwung @babel-bot @existentialism @kaicataldo