[parser] Better error message for missing number exponent #12072

iamfotx · 2020-09-17T22:37:38Z

fix(babel-parser) better error message for missing number exponent

Q	A
Fixed Issues?	Fixes #12071
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

…ter 'e'

nicolo-ribaudo · 2020-09-17T22:39:45Z

packages/babel-parser/src/parser/error-message.js

@@ -71,6 +71,8 @@ export const ErrorMessages = Object.freeze({
  InvalidLhs: "Invalid left-hand side in %0",
  InvalidLhsBinding: "Binding invalid left-hand side in %0",
  InvalidNumber: "Invalid number",
+  InvalidOrMissingExponent:
+    "Invalid or Missing exponent after 'e' in floating-point number",


Thanks! Could you just make this lowercase? (don't use GH's "Apply changes" button because you need to regenerate the tests locally)

Suggested change

"Invalid or Missing exponent after 'e' in floating-point number",

"Invalid or missing exponent after 'e' in floating-point number",

Or maybe just delete "Invalid or", I don't have a preference in either direction.

Yeah I think we can drop "Invalid or" or:

"Floating-point numbers require a valid exponent after the 'e'."

@nicolo-ribaudo , what do you think if I work around and throw accordingly by figuring out if it is actually missing or invalid?

For example: 3ea would also throw with the same error message. I would consider, it (3ea) is invalid, that's why I used "invalid"...

babel-bot · 2020-09-17T22:42:18Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/29948/

codesandbox-ci · 2020-09-17T22:47:12Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4d5ef93:

Sandbox	Source
babel-repl-custom-plugin	Configuration
babel-plugin-multi-config	Configuration

existentialism · 2020-10-02T14:37:09Z

I still prefer:

"Floating-point numbers require a valid exponent after the 'e'."

Whops, GH is collapsing the inline discussion and I didn't remember about it 😅

kaicataldo · 2020-10-10T04:07:13Z

@iamfotx Anything we can do to help get this landed? Looks like we just need to change the error message.

nicolo-ribaudo · 2020-10-14T18:28:31Z

(adding to the milestone so we don't forget to merge when the tests pass)

nicolo-ribaudo · 2020-10-14T19:16:55Z

The failing test is also failing in main.

* Install babel/parser 7.12 * Add tests for babel/babel#12161 * Add test for babel/babel#12076 * Add test for babel/babel#12085 * Add test for babel/babel#12108 * Add test for babel/babel#12120 * Add test for babel/babel#12054 * Add test for babel/babel#12061 * Add test babel/babel#12093 * Add test for babel/babel#12065 * Add test for babel/babel#12111 * Add test for babel/babel#12072 * Switch syntax-module-attributes to syntax-import-assertion * Support "String import/export specifier" * Remove tests for module-attributes * Add changelog * Update to 7.12.3 * Fix by linter * Fix by spellchecker * Add tests for module attributes to errors * Add error test for module string name with import * Remove TSTypeCastExpression * Add tests for funny import-assertions * Update snapshots| * Add more tests

fix(babel-parser) better error message for missing number exponent af…

72a091c

…ter 'e'

nicolo-ribaudo reviewed Sep 17, 2020

View reviewed changes

nicolo-ribaudo added area: errors pkg: parser PR: Polish 💅 A type of pull request used for our changelog categories labels Sep 17, 2020

fix(babel-parser) requested changes

69476a4

nicolo-ribaudo previously approved these changes Oct 2, 2020

View reviewed changes

JLHwung approved these changes Oct 2, 2020

View reviewed changes

msg

4d5ef93

existentialism approved these changes Oct 14, 2020

View reviewed changes

nicolo-ribaudo added this to the v7.12.0 milestone Oct 14, 2020

nicolo-ribaudo changed the title ~~fix(babel-parser) better error message for missing number exponent~~ [parser] Better error message for missing number exponent Oct 14, 2020

nicolo-ribaudo merged commit 59d97d9 into babel:main Oct 14, 2020

fisker mentioned this pull request Oct 15, 2020

Update @babel/parser to 7.12 prettier/prettier#9408

Merged

3 tasks

sosukesuzuki added a commit to sosukesuzuki/prettier that referenced this pull request Oct 16, 2020

Add test for babel/babel#12072

e418282

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 14, 2021

github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[parser] Better error message for missing number exponent #12072

[parser] Better error message for missing number exponent #12072

iamfotx commented Sep 17, 2020 •

edited by gitpod-io bot

nicolo-ribaudo Sep 17, 2020

nicolo-ribaudo Sep 17, 2020

existentialism Sep 17, 2020 •

edited

iamfotx Sep 17, 2020 •

edited

babel-bot commented Sep 17, 2020 •

edited

codesandbox-ci bot commented Sep 17, 2020 •

edited

existentialism commented Oct 2, 2020

kaicataldo commented Oct 10, 2020

nicolo-ribaudo commented Oct 14, 2020

nicolo-ribaudo commented Oct 14, 2020

	"Invalid or Missing exponent after 'e' in floating-point number",
	"Invalid or missing exponent after 'e' in floating-point number",

[parser] Better error message for missing number exponent #12072

[parser] Better error message for missing number exponent #12072

Conversation

iamfotx commented Sep 17, 2020 • edited by gitpod-io bot

nicolo-ribaudo Sep 17, 2020

Choose a reason for hiding this comment

nicolo-ribaudo Sep 17, 2020

Choose a reason for hiding this comment

existentialism Sep 17, 2020 • edited

Choose a reason for hiding this comment

iamfotx Sep 17, 2020 • edited

Choose a reason for hiding this comment

babel-bot commented Sep 17, 2020 • edited

codesandbox-ci bot commented Sep 17, 2020 • edited

existentialism commented Oct 2, 2020

kaicataldo commented Oct 10, 2020

nicolo-ribaudo commented Oct 14, 2020

nicolo-ribaudo commented Oct 14, 2020

iamfotx commented Sep 17, 2020 •

edited by gitpod-io bot

existentialism Sep 17, 2020 •

edited

iamfotx Sep 17, 2020 •

edited

babel-bot commented Sep 17, 2020 •

edited

codesandbox-ci bot commented Sep 17, 2020 •

edited