New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid setter
parse
#12076
Fix invalid setter
parse
#12076
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/28556/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8a15677:
|
"type": "File", | ||
"start":0,"end":15,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":15}}, | ||
"errors": [ | ||
"SyntaxError: setter must have exactly one formal parameter (1:3)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, but I think we can improve this error message:
A setter must have exactly one parameter.
Or Typescript's:
A 'set' accessor must have exactly one parameter.
@fisker That similar code is used when producing an ESTree-compliant AST. You can test it enabling the |
@nicolo-ribaudo Thanks for this guidance, but I'm not near the laptop I used to make this PR, and I don't want setup environment on another computer, it took me a while to make it run. Can you help me test/fix it? |
@fisker I got you |
Thank you! |
I wonder if this part can use the new logic? |
@fisker I'd say we can do that in a follow-up, as it requires more breaking things up ( |
Okay, thank you very much. |
* Install babel/parser 7.12 * Add tests for babel/babel#12161 * Add test for babel/babel#12076 * Add test for babel/babel#12085 * Add test for babel/babel#12108 * Add test for babel/babel#12120 * Add test for babel/babel#12054 * Add test for babel/babel#12061 * Add test babel/babel#12093 * Add test for babel/babel#12065 * Add test for babel/babel#12111 * Add test for babel/babel#12072 * Switch syntax-module-attributes to syntax-import-assertion * Support "String import/export specifier" * Remove tests for module-attributes * Add changelog * Update to 7.12.3 * Fix by linter * Fix by spellchecker * Add tests for module attributes to errors * Add error test for module string name with import * Remove TSTypeCastExpression * Add tests for funny import-assertions * Update snapshots| * Add more tests
I'm new to this codebase, not sure is this enough. If I'm missing anything, just let me know.
Found another similar code here, not sure if it has similar issue, and not sure how to test it.