Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @babel/generator does not print decorators of private properties #12081

Merged
merged 1 commit into from Sep 25, 2020

Conversation

zweimach
Copy link
Contributor

@zweimach zweimach commented Sep 19, 2020

Hey, thank you all for developing and maintaining Babel.

I think I managed to fix this one.
Do I need to add more tests?

Q A
Fixed Issues? Fixes #10149
Patch: Bug Fix? Bug Fix
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/28627/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9131bd1:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JLHwung JLHwung added pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Sep 24, 2020
@existentialism existentialism merged commit af612db into babel:main Sep 25, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 26, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2020
@zweimach zweimach deleted the private-props branch February 15, 2021 00:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@babel/generator does not print decorators of private properties
4 participants