Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sourcemap markings for each line of a string #12086

Merged
merged 4 commits into from Sep 23, 2020

Conversation

jridgewell
Copy link
Member

@jridgewell jridgewell commented Sep 20, 2020

Q                       A
Fixed Issues? Fixes #12083
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Template literals and string literals can span multiple lines (string literals can through the LineContinuation grammar). Each of the lines should have at least one sourcemap marking, so that we can trace back to the source literal.

You can see a sample of the generated output:

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 20, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b5ed542:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Sep 20, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/28679/

@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: sourcemaps pkg: generator labels Sep 21, 2020
@JLHwung JLHwung merged commit f49234a into babel:main Sep 23, 2020
@jridgewell jridgewell deleted the sourcemap-newline branch September 25, 2020 18:24
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: sourcemaps outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect source maps for template strings containing line breaks
4 participants