String import/export specifier #12091

JLHwung · 2020-09-22T01:17:12Z

Q	A
Fixed Issues?	Implements tc39/ecma262#2154
Minor: New Feature?	Yes
Tests Added + Pass?	Yes
Documentation PR Link	babel/website#2396
Any Dependency Changes?	`@babel/helper-module-transforms` now depends on `@babel/helper-validator-identifier`
License	MIT

This PR implements support of Arbitrary module namespace identifier names behind moduleStringNames parser plugin

import { "some imports" as foo } from "module"
export { foo as "some exports" } from "module"
export { "another imports" as "another exports" } from "module"
export { "rest exports" } from "module"

Babel can now parse such code and transform it to CommonJS/AMD/UMD/SystemJS code. Take CommonJS as an output example

const m = require("module");
foo = m["some imports"];
exports["some exports"] = m.foo;
exports["another exports"] = m["another imports"];
exports["rest exports"] = m["rest exports"];

A new package @babel/plugin-syntax-module-string-names is introduced. See also https://github.com/babel/babel/pull/12091/files#diff-ef433cb06c064c1e7a5af0f448d98a78 for AST spec changes.

Todo:

umd-transform
amd-transform
systemjs-transform (/cc @guybedford)

babel-bot · 2020-09-22T01:22:27Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/29849/

codesandbox-ci · 2020-09-22T01:25:24Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 107444b:

Sandbox	Source
babel-repl-custom-plugin	Configuration
babel-plugin-multi-config	Configuration

...abel-plugin-transform-modules-systemjs/test/fixtures/systemjs/export-named-string/output.mjs

guybedford

SystemJS output looks great, and glad it fixed some bugs too.

packages/babel-parser/src/parser/statement.js

nicolo-ribaudo

I think that we should introduce this behind a syntax plugin. Even if the spec PR has consensus, it will still take a while to be merged because it doesn't have tests.

Also, for example tc39/ecma262#1174 still took a few months after having consensus and tests.

nicolo-ribaudo

Except for a question (maybe small error) this looks good 👍

nicolo-ribaudo · 2020-10-09T12:59:23Z

packages/babel-parser/ast/spec.md

-  exported: Identifier;
-  local?: Identifier;
+  exported: Identifier | StringLiteral;
+  local?: Identifier | StringLiteral;


When can local be a string?

export { "😄" as "😂" } from "emojis"

packages/babel-parser/src/parser/error-message.js

Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>

packages/babel-parser/src/parser/error-message.js

existentialism

Looks great! Just some 🚲shedding on error messages.

Co-authored-by: Brian Ng <bng412@gmail.com>

* feat: parse moduleExportName * feat: add validators * Support string specifier name in commonjs transform * Support string specifier name in export-ns-from * test: add loose testcases * test: add testcases for amd and umd * feat: support systemjs * test: update fixtures fixed in #12110 * add plugin name typings * test: rename test layout * feat: implement under moduleStringNames flag * chore: add plugin syntax module string names * feat: support ModuleExportName as ModuleExportName * test: update test fixtures * fix flow errors * docs: update AST spec * feat: support { "some imports" as "some exports" } * feat: support { "some imports" as "some exports" } in systemjs * test: add test on `import { "foo" }` * Address review comments * add moduleStringNames to missing plugin helpers * Apply suggestions from code review * update test fixtures * Update packages/babel-parser/src/parser/error-message.js * update test fixtures Co-Authored-By: Kai Cataldo <kai@kaicataldo.com> Co-authored-by: Brian Ng <bng412@gmail.com>

JLHwung added PR: Spec Compliance 👓 A type of pull request used for our changelog categories PR: New Feature 🚀 A type of pull request used for our changelog categories labels Sep 22, 2020

JLHwung added this to the v7.12.0 milestone Sep 22, 2020

JLHwung force-pushed the string-module-specifier-name branch from bd69ecd to 425637a Compare September 22, 2020 20:56

JLHwung commented Sep 22, 2020

View reviewed changes

...abel-plugin-transform-modules-systemjs/test/fixtures/systemjs/export-named-string/output.mjs Outdated Show resolved Hide resolved

JLHwung marked this pull request as ready for review September 22, 2020 21:01

JLHwung mentioned this pull request Sep 25, 2020

Fix reexporting init-less variable in systemjs #12110

Merged

JLHwung force-pushed the string-module-specifier-name branch 2 times, most recently from d7f2778 to c50c767 Compare September 25, 2020 21:07

guybedford approved these changes Sep 26, 2020

View reviewed changes

nicolo-ribaudo reviewed Sep 26, 2020

View reviewed changes

packages/babel-parser/src/parser/statement.js Show resolved Hide resolved

nicolo-ribaudo reviewed Sep 26, 2020

View reviewed changes

JLHwung force-pushed the string-module-specifier-name branch from c50c767 to c63fd3c Compare September 28, 2020 15:39

JLHwung changed the title ~~String module specifier name~~ String import/export specifier Sep 28, 2020

JLHwung force-pushed the string-module-specifier-name branch 4 times, most recently from 7ba178b to 6f141a2 Compare September 30, 2020 12:59

JLHwung requested a review from nicolo-ribaudo September 30, 2020 14:03

JLHwung added the PR: Needs Review A pull request awaiting more approvals label Oct 8, 2020

nicolo-ribaudo approved these changes Oct 9, 2020

View reviewed changes

JLHwung force-pushed the string-module-specifier-name branch from f71402b to 6e0d7bf Compare October 9, 2020 18:37

kaicataldo approved these changes Oct 10, 2020

View reviewed changes

packages/babel-parser/src/parser/error-message.js Outdated Show resolved Hide resolved

nicolo-ribaudo removed the PR: Needs Review A pull request awaiting more approvals label Oct 11, 2020

JLHwung added 4 commits October 12, 2020 13:58

feat: parse moduleExportName

db00d85

feat: add validators

356fd9e

Support string specifier name in commonjs transform

1a6b13f

Support string specifier name in export-ns-from

00276bc

JLHwung and others added 11 commits October 12, 2020 13:58

test: rename test layout

e2e1d0b

feat: implement under moduleStringNames flag

e14a03a

chore: add plugin syntax module string names

ae9d87a

feat: support ModuleExportName as ModuleExportName

c6d3069

test: update test fixtures

41407f4

fix flow errors

f5759d0

docs: update AST spec

ec66634

feat: support { "some imports" as "some exports" }

4f8fce4

feat: support { "some imports" as "some exports" } in systemjs

823b67b

test: add test on import { "foo" }

04fa4bf

Address review comments

0b4dc58

Co-Authored-By: Kai Cataldo <kai@kaicataldo.com>

JLHwung force-pushed the string-module-specifier-name branch from 6e0d7bf to 0b4dc58 Compare October 12, 2020 17:59

add moduleStringNames to missing plugin helpers

9f9597b

existentialism reviewed Oct 12, 2020

View reviewed changes

packages/babel-parser/src/parser/error-message.js Outdated Show resolved Hide resolved

existentialism reviewed Oct 12, 2020

View reviewed changes

packages/babel-parser/src/parser/error-message.js Outdated Show resolved Hide resolved

existentialism reviewed Oct 12, 2020

View reviewed changes

packages/babel-parser/src/parser/error-message.js Outdated Show resolved Hide resolved

existentialism approved these changes Oct 12, 2020

View reviewed changes

JLHwung and others added 4 commits October 12, 2020 16:18

Apply suggestions from code review

5f8e9b7

Co-authored-by: Brian Ng <bng412@gmail.com>

update test fixtures

f67fba1

Update packages/babel-parser/src/parser/error-message.js

62e7d55

Co-authored-by: Brian Ng <bng412@gmail.com>

update test fixtures

107444b

existentialism added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Oct 12, 2020

nicolo-ribaudo merged commit cb30c1d into babel:main Oct 14, 2020

nicolo-ribaudo deleted the string-module-specifier-name branch October 14, 2020 17:59

fisker mentioned this pull request Oct 15, 2020

Update @babel/parser to 7.12 prettier/prettier#9408

Merged

3 tasks

ExE-Boss mentioned this pull request Oct 22, 2020

Support “Arbitrary module namespace identifier names” microsoft/TypeScript#40594

Open

5 tasks

alangpierce mentioned this pull request Dec 3, 2020

Allow non-identifier imported and exported names in imports transform alangpierce/sucrase#565

Open

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 14, 2021

github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

String import/export specifier #12091

String import/export specifier #12091

JLHwung commented Sep 22, 2020 •

edited by gitpod-io bot

babel-bot commented Sep 22, 2020 •

edited

codesandbox-ci bot commented Sep 22, 2020 •

edited

guybedford left a comment

nicolo-ribaudo left a comment

nicolo-ribaudo left a comment

nicolo-ribaudo Oct 9, 2020

JLHwung Oct 9, 2020

existentialism left a comment

String import/export specifier #12091

String import/export specifier #12091

Conversation

JLHwung commented Sep 22, 2020 • edited by gitpod-io bot

babel-bot commented Sep 22, 2020 • edited

codesandbox-ci bot commented Sep 22, 2020 • edited

guybedford left a comment

Choose a reason for hiding this comment

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

nicolo-ribaudo left a comment

Choose a reason for hiding this comment

nicolo-ribaudo Oct 9, 2020

Choose a reason for hiding this comment

JLHwung Oct 9, 2020

Choose a reason for hiding this comment

existentialism left a comment

Choose a reason for hiding this comment

JLHwung commented Sep 22, 2020 •

edited by gitpod-io bot

babel-bot commented Sep 22, 2020 •

edited

codesandbox-ci bot commented Sep 22, 2020 •

edited