Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark Pattern in CatchClause as scope #12119

Merged
merged 1 commit into from Sep 29, 2020

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Sep 28, 2020

Q                       A
Fixed Issues? Fixes​ #12032 (comment)
Patch: Bug Fix? Yes
Tests Added + Pass? Yes
License MIT

This PR is a follow-up to #10912. The procedures of function is applied to catch clause. It also tweaks performance a bit.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: traverse (scope) labels Sep 28, 2020
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/28958/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 95a544a:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung JLHwung merged commit e0b2bfb into babel:main Sep 29, 2020
@JLHwung JLHwung deleted the fix-rename-in-catch-clause-pattern branch September 29, 2020 19:04
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 30, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: traverse (scope) PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants