Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[transform-typescript] Fix import elision for type exports #12122

Merged
merged 1 commit into from Sep 29, 2020

Conversation

Amareis
Copy link
Contributor

@Amareis Amareis commented Sep 29, 2020

Q                       A
Fixed Issues? Fixes #12121
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT

Pretty small change.

@babel-bot
Copy link
Collaborator

babel-bot commented Sep 29, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/29025/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9af4465:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo added area: typescript PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Sep 29, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 29, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3c573bc:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@Amareis
Copy link
Contributor Author

Amareis commented Sep 29, 2020

Looks like it's not my code error, but some unrelated infrastructure fail.

@JLHwung
Copy link
Contributor

JLHwung commented Sep 29, 2020

@Amareis The e2e error has been fixed on upstream. Please rebase.

@Amareis
Copy link
Contributor Author

Amareis commented Sep 29, 2020

@Amareis The e2e error has been fixed on upstream. Please rebase.

Done.

@existentialism existentialism merged commit 7ad9917 into babel:main Sep 29, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 30, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PR included!] [transform-typescript] Imports which used only in type exports is not elided
5 participants