Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support TypeScript mapped type 'as' clauses #12129

Merged
merged 2 commits into from Oct 14, 2020
Merged

Support TypeScript mapped type 'as' clauses #12129

merged 2 commits into from Oct 14, 2020

Conversation

existentialism
Copy link
Member

@existentialism existentialism commented Oct 1, 2020 •
edited by gitpod-io bot

Q                       A
Fixed Issues?
Minor: New Feature? Y
License MIT

@existentialism existentialism added PR: New Feature 🚀 A type of pull request used for our changelog categories area: typescript labels Oct 1, 2020
@babel-bot
Copy link
Collaborator

babel-bot commented Oct 1, 2020 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/29209/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 1, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 63217af:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo added this to the v7.12.0 milestone Oct 1, 2020
@existentialism existentialism marked this pull request as ready for review October 2, 2020 14:40
@JLHwung
Copy link
Contributor

JLHwung commented Oct 2, 2020

Note that parts of syntax changes introduced in mapped type 'as' clauses is superseded by Intrinsic string types. We should support intrinsic as keyword in TS4.1.

@existentialism existentialism added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Oct 2, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit 6830c90 into main Oct 14, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the mapped-as branch October 14, 2020 18:16
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release
Projects
None yet
Milestone
v7.12.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@existentialism @babel-bot @JLHwung @nicolo-ribaudo @kaicataldo