Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ts] Add support for template interpolations in types #12131

Merged
merged 5 commits into from Oct 14, 2020
Merged

[ts] Add support for template interpolations in types #12131

merged 5 commits into from Oct 14, 2020

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Oct 1, 2020 •
edited by gitpod-io bot

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

https://devblogs.microsoft.com/typescript/announcing-typescript-4-1-beta/#template-literal-types

@nicolo-ribaudo nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: parser area: typescript labels Oct 1, 2020
@nicolo-ribaudo nicolo-ribaudo added this to the v7.12.0 milestone Oct 1, 2020
@babel-bot
Copy link
Collaborator

babel-bot commented Oct 1, 2020 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/29203/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 1, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0648b48:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

JLHwung
JLHwung reviewed Oct 1, 2020
View reviewed changes
packages/babel-parser/src/parser/expression.js Outdated
@@ -1605,14 +1605,19 @@ export default class ExpressionParser extends LValParser {
node.quasis = [curElt];
while (!curElt.tail) {
this.expect(tt.dollarBraceL);
node.expressions.push(this.parseExpression());
node.expressions.push(this.parseTemplateInterpolation());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we extend parseTemplate in typescript plugin? since it seems to me that TemplateInterpolation is a TS-only concept.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it the same concept as for js? i.e. a${x}b is valid both in TS and in JS.
Maybe if I call it parseTemplateSubstitution, which is the language used in the spec?

nicolo-ribaudo
nicolo-ribaudo commented Oct 1, 2020
View reviewed changes
scripts/parser-tests/typescript/allowlist.txt
@@ -226,6 +226,7 @@ gettersAndSettersErrors.ts
giant.ts
globalThisDeclarationEmit.ts
globalThisDeclarationEmit2.ts
hugeDeclarationOutputGetsTruncatedWithError.ts
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a type analysis error, it can't be caught at parse time.

@nicolo-ribaudo @existentialism
typo
0648b48 
Co-authored-by: Brian Ng <bng412@gmail.com>
@JLHwung JLHwung added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Oct 8, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit 3fd963f into babel:main Oct 14, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the ts-template-types branch October 14, 2020 18:15
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser pkg: types PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release
Projects
None yet
Milestone
v7.12.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicolo-ribaudo @babel-bot @existentialism @JLHwung