Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse import-assertions #12139

Merged
merged 10 commits into from Oct 14, 2020
Merged

Parse import-assertions #12139

merged 10 commits into from Oct 14, 2020

Conversation

xtuc
Copy link
Member

@xtuc xtuc commented Oct 3, 2020 •
edited by gitpod-io bot

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 3, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 39838f0:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo added this to the v7.12.0 milestone Oct 3, 2020
@JLHwung JLHwung added PR: New Feature 🚀 A type of pull request used for our changelog categories Spec: Import Attributes labels Oct 3, 2020
@babel-bot
Copy link
Collaborator

babel-bot commented Oct 4, 2020 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/29942/

JLHwung
JLHwung reviewed Oct 7, 2020
View reviewed changes
packages/babel-generator/src/generators/modules.js
@@ -180,11 +180,15 @@ export function ImportDeclaration(node: Object) {

this.print(node.source, node);

if (node.attributes?.length) {
if (node.assertions?.length) {
Copy link
Contributor

@JLHwung JLHwung Oct 7, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It seems that import foo from "foo.json" assert {} are now generated as import foo from "foo.json". Although it is semantically equivalent. I slightly prefer to reserve asserts {} if node.assertions is not nullish.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that current AST design does not differentiate between import foo from "foo.json" assert {} and import foo from "foo.json". Both of them have assertions set to [].

@JLHwung JLHwung changed the title Rename module-attributes to import-assertions Parse import-assertions Oct 8, 2020
@JLHwung JLHwung force-pushed the sven/rename-module-attributes-to-import-assertions branch 2 times, most recently from f998d24 to ed15a13 Compare October 8, 2020 15:03
@JLHwung JLHwung force-pushed the sven/rename-module-attributes-to-import-assertions branch from 3cec529 to 343a6be Compare October 12, 2020 19:24
@nicolo-ribaudo nicolo-ribaudo added the PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release label Oct 13, 2020
@JLHwung JLHwung force-pushed the sven/rename-module-attributes-to-import-assertions branch from d6dae66 to 39838f0 Compare October 14, 2020 18:17
@nicolo-ribaudo
Copy link
Member

The failing test is also failing in main.

@nicolo-ribaudo nicolo-ribaudo merged commit af8e0fa into main Oct 14, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the sven/rename-module-attributes-to-import-assertions branch October 14, 2020 19:18
@fisker fisker mentioned this pull request Oct 15, 2020
Merged
3 tasks
@alangpierce alangpierce mentioned this pull request Dec 5, 2020
Closed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release Spec: Import Attributes
Projects
None yet
Milestone
v7.12.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xtuc @babel-bot @nicolo-ribaudo @JLHwung