[ts] Add support for the "intrinsic" keyword #12147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: New Feature 🚀
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/29511/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5f47c84:
|
existentialism
approved these changes
Oct 7, 2020
JLHwung
reviewed
Oct 7, 2020
| node.typeAnnotation = this.tsInType(() => { | ||
| this.expect(tt.eq); | ||
|
|
||
| if (this.isContextual("intrinsic")) { |
There was a problem hiding this comment.
If a dot token is after contextual "intrinsic", then "intrinsic" is not considered as an TSIntrinsicKeyword:
https://github.com/microsoft/TypeScript/pull/40580/files#diff-ead24f0f0f59c0ea9c1c511052e8884bR6745
namespace intrinsic {
export class Foo {}
}
type Foo = intrinsic.Foo;
JLHwung
approved these changes
Oct 7, 2020
existentialism
added
the
PR: Ready to be Merged
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I understood from the TS PR,
intrinsicis a keyword only when it's immediately after=in a type declaration.Hopefully TS will have a spec one day 😛