Flow Enums with unknown members support #12193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b459a86:
|
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/41501/ |
|
The errors in |
|
For the failing tests, could you try rebasing? |
existentialism
added
PR: New Feature 🚀
gkz
force-pushed
the
flow-enums-unknown-members
branch
2 times, most recently
from
11ba364
to
ef0e48d
Compare
existentialism
approved these changes
Oct 21, 2020
|
Does this look OK? |
hzoo
approved these changes
Dec 4, 2020
nicolo-ribaudo
added
the
PR: Ready to be Merged
nicolo-ribaudo
force-pushed
the
flow-enums-unknown-members
branch
from
ef0e48d
to
b459a86
Compare
This was referenced Mar 6, 2021
Closed
Merged
This was referenced Mar 14, 2021
Merged
build(deps): bump @babel/plugin-proposal-decorators from 7.10.5 to 7.13.5
ChatterlyOSE/Chatterly#594
Closed
Bump @babel/plugin-proposal-class-properties from 7.12.1 to 7.13.0 in /desktop
vamshi9666/flipper#72
Closed
Merged
Merged
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for parsing of Flow Enums with unknown members (as well as printing).
Example:
This is already supported in Flow Parser: facebook/flow@de2296c