Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test case for babel-parser: fixtures/typescript/arrow-function/destructuring-with-annotation-newline #12203

Conversation

Mongkii
Copy link
Contributor

@Mongkii Mongkii commented Oct 16, 2020

Q                       A
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT

Add test case for @babel/parser, in fixtures/typescript/arrow-function.

The test babel-parser/estree-throws will now test the situation: "Typescript arrow function with arguments destructuring, type annotations and multiline". (See below)

(
  { a, b }: T,
): T => {};

In order to avoid bugs like #12195

@Mongkii Mongkii changed the title test: add test case for babel-parser: fixtures/typescript/arrow-funct… test: add test case for babel-parser: fixtures/typescript/arrow-function/destructuring-with-annotation-newline Oct 16, 2020
@JLHwung JLHwung added area: tests PR: Internal 🏠 A type of pull request used for our changelog categories labels Oct 16, 2020
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/30318/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 60e2302:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo
Copy link
Member

Thanks!

Fyi, I'm also working on #12202 which hopefully will help catching some TS regressions in the future.

@nicolo-ribaudo nicolo-ribaudo merged commit 7870465 into babel:main Oct 16, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: tests outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants