Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @babel/core support for the new assumptions option #12219

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Oct 19, 2020

Q                       A
Fixed Issues? RFC: babel/rfcs#5 <-- Please read and review it!
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This PR only introduces support for the assumptions option in @babel/core. I will make plugins check it in separate PRs, otherwise this one would be too big to be properly reviewed.

Assumptions implementation:

Those PRs can be reviewed one by one (you can even review those PRs before this one), and I'll merge them here after that both this PR and the specific implementation PR have been approved.

@nicolo-ribaudo nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: core labels Oct 19, 2020
@@ -229,55 +217,65 @@ function enhanceError<T: Function>(context, fn: T): T {
/**
* Load a generic plugin/preset from the given descriptor loaded from the config object.
*/
const loadDescriptor = makeWeakCache(function* (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When reviewing this file, turn off whitespace diff

@babel-bot
Copy link
Collaborator

babel-bot commented Oct 19, 2020

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/34632/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 19, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8affe9b:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo force-pushed the nicolo-ribaudo/targets-in-core branch 2 times, most recently from 58a1e84 to 1f501e0 Compare November 4, 2020 14:40
@nicolo-ribaudo nicolo-ribaudo marked this pull request as ready for review November 13, 2020 16:36
@nicolo-ribaudo nicolo-ribaudo force-pushed the assumptions branch 3 times, most recently from 3d44f35 to 9aaf0da Compare November 27, 2020 15:14
@nicolo-ribaudo nicolo-ribaudo force-pushed the assumptions branch 2 times, most recently from 985ccbf to 9b673e3 Compare November 27, 2020 15:31
@nicolo-ribaudo nicolo-ribaudo force-pushed the assumptions branch 2 times, most recently from da76ea2 to c12cc57 Compare November 27, 2020 15:52
@nicolo-ribaudo nicolo-ribaudo added this to To review in Nicolò's ideal PR review order list via automation Dec 2, 2020
@nicolo-ribaudo nicolo-ribaudo moved this from To review to Reviewed in Nicolò's ideal PR review order list Dec 8, 2020
nicolo-ribaudo added a commit to nicolo-ribaudo/babel that referenced this pull request Jan 12, 2021
nicolo-ribaudo added a commit to nicolo-ribaudo/babel that referenced this pull request Feb 4, 2021
nicolo-ribaudo added a commit to nicolo-ribaudo/babel that referenced this pull request Feb 10, 2021
nicolo-ribaudo added a commit to nicolo-ribaudo/babel that referenced this pull request Feb 11, 2021
nicolo-ribaudo added a commit that referenced this pull request Feb 16, 2021
- Disallow setting assumptions to `false` in presets (#12498)
nicolo-ribaudo added a commit that referenced this pull request Feb 21, 2021
- Disallow setting assumptions to `false` in presets (#12498)
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: core PR: New Feature 🚀 A type of pull request used for our changelog categories
Development

Successfully merging this pull request may close these issues.

None yet

4 participants