New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @babel/core
support for the new assumptions
option
#12219
Add @babel/core
support for the new assumptions
option
#12219
Conversation
@@ -229,55 +217,65 @@ function enhanceError<T: Function>(context, fn: T): T { | |||
/** | |||
* Load a generic plugin/preset from the given descriptor loaded from the config object. | |||
*/ | |||
const loadDescriptor = makeWeakCache(function* ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When reviewing this file, turn off whitespace diff
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/34632/ |
4c025f5
to
ff20f60
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8affe9b:
|
a196b73
to
46dae56
Compare
58a1e84
to
1f501e0
Compare
ff20f60
to
8f16324
Compare
1f501e0
to
7f6a7d8
Compare
3d44f35
to
9aaf0da
Compare
985ccbf
to
9b673e3
Compare
da76ea2
to
c12cc57
Compare
085be04
to
7bb7925
Compare
so that it doesn't override assumptions
- Disallow setting assumptions to `false` in presets (#12498)
- Disallow setting assumptions to `false` in presets (#12498)
This PR only introduces support for the
assumptions
option in@babel/core
. I will make plugins check it in separate PRs, otherwise this one would be too big to be properly reviewed.Assumptions implementation:
setClassMethods
: ImplementsetClassMethods
assumption #12407mutableTemplateObject
,ignoreToPrimitiveHint
: ImplementmutableTemplateObject
andignoreToPrimitiveHint
#12408Those PRs can be reviewed one by one (you can even review those PRs before this one), and I'll merge them here after that both this PR and the specific implementation PR have been approved.