Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for polyfilling Array.prototype.values in core-js@2 #12340

Merged
merged 1 commit into from Nov 10, 2020

Conversation

existentialism
Copy link
Member

@existentialism existentialism commented Nov 10, 2020

Q                       A
Fixed Issues?
Patch: Bug Fix? Y
Tests Added + Pass? N/Y
License MIT

I was chatting with @hzoo about this since the comment goes back to when we first created preset-env... and it seems (???) like at the time we might have not included this in the features list for es6.array.iterator because there were not any environments that implemented it at the time (?). But to be honest, not sure. I actually ran into a case within a codebase that used this and preset-env didn't include the polyfill properly.

(Alternative is we can update the documentation to instruct people to include: [es6.array.iterator] if you're using Array.prototype.values(), but that definitely would be unexpected.)

@existentialism existentialism added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: preset-env labels Nov 10, 2020
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is strange.

Could you also check if it needs to be added to the babel-polyfills repo?

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8b2ff64:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo merged commit 08c7280 into main Nov 10, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the corejs2-array-values branch November 10, 2020 15:43
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants