Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct path.context un push/unshiftContainer #12394

Merged
merged 1 commit into from Nov 25, 2020

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Nov 24, 2020

Q                       A
Fixed Issues?
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Both the test cases in this PR are failing without the .setContext() calls. The first one with "cannot read .skipKeys of null (because pushContianer uses a NodePath not in the cache) and the second one with ["consequent"] != [] (because it re-uses the options from the inner traversal).

path.opts in this PR is a direct side effect of not having the correct context, and it can cause problem when requeuing (since paths could be requeued in an "inactive" context of a nested path.traverse finished call).

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: traverse labels Nov 24, 2020
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/33201/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bdb738c:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@@ -78,6 +98,26 @@ describe("modification", function () {
},
});
});

it("should set the correct path.context", function () {
expect.assertions(2);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add this to all the tests where we expect inside a visitor, just in case the visitor doesn't get called!

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference only, this PR fixes regression introduced in #12331. The fix here is complete as it covers all the NodePath.get usage in @babel/traverse.

@nicolo-ribaudo nicolo-ribaudo merged commit 695abb8 into babel:main Nov 25, 2020
@nicolo-ribaudo nicolo-ribaudo deleted the context-push-unshift branch November 25, 2020 15:52
nicolo-ribaudo added a commit to nicolo-ribaudo/babel that referenced this pull request Dec 2, 2020
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: traverse PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants