Clarify warning source about underspecified corejs option in preset-env. #12402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/33649/ |
AndrewSouthpaw
force-pushed
the
clarify-warning-source
branch
from
5e4591f
to
c0ac148
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8fd93bc:
|
AndrewSouthpaw
changed the title
Comment on lines
163
to
164
| "\n[babel-preset-env]" + | ||
| "\nWARNING: We noticed you're using the `useBuiltIns` option without declaring a " + |
There was a problem hiding this comment.
I'd prefer something like
Suggested change
| "\n[babel-preset-env]" + | |
| "\nWARNING: We noticed you're using the `useBuiltIns` option without declaring a " + | |
| "\nWARNING (@babel/preset-env): We noticed you're using the `useBuiltIns` option without declaring a " + |
Comment on lines
189
to
190
| "\n[babel-preset-env]" + | ||
| "\nThe `corejs` option only has an effect when the `useBuiltIns` option is not `false`\n", |
There was a problem hiding this comment.
And also here:
Suggested change
| "\n[babel-preset-env]" + | |
| "\nThe `corejs` option only has an effect when the `useBuiltIns` option is not `false`\n", | |
| "\nWARNING (@babel/preset-env): The `corejs` option only has an effect when the `useBuiltIns` option is not `false`\n", |
(this is not technically a warning, but since it's probably an error in the user's config it's good to mark it as such).
nicolo-ribaudo
added
area: errors
pkg: preset-env
PR: Polish 💅
|
Thanks for the review! I'll work on those changes. |
|
Okay, changes are up. |
existentialism
approved these changes
Dec 1, 2020
nicolo-ribaudo
approved these changes
Dec 1, 2020
|
Thanks! |
nicolo-ribaudo
pushed a commit
to nicolo-ribaudo/babel
that referenced
this pull request
Dec 2, 2020
…nv. (babel#12402) * Clarify these warnings are for babel-preset-env. * Fix lint. * Fix specs. * Fix merge conflict. * PR feedback.
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stumbled across the warning about using
useBuiltInswithout declaring a core-js version. It took me a fair bit of hunting before I realized it belonged to preset-env, and how to fix the issue. From the docs, I thought all I needed to do was install the package, which (I now see obviously) didn't fix the problem.I'm not sure if some expanded logging like this would be desired, but I could imagine it'll reduce confusion for people by adding a little tag to the warning printout, so they know this is coming from this package. I've definitely run into this error multiple times when starting projects and was confused as to what to do.
I think I got all the tests to pass, I was getting some issues with
caniuse-litebeing outdated and complaining about it, but I couldn't seem to make it go away. Sorry if I got it wrong, this is my first time contributing to babel.