Fix printing BigIntLiterals/DecimalLiterals with compact option #12424
Conversation
existentialism
commented
Nov 30, 2020
•
existentialism
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #12423 |
| Patch: Bug Fix? | Y |
| License | MIT |
existentialism
added
the
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/33642/ |
| @@ -216,19 +216,19 @@ export function StringLiteral(node: Object) { | |||
| export function BigIntLiteral(node: Object) { | |||
| const raw = this.getPossibleRaw(node); | |||
| if (!this.format.minified && raw != null) { | |||
| this.token(raw); | |||
| this.word(raw); | |||
There was a problem hiding this comment.
@nicolo-ribaudo @JLHwung we could also use this.number here if clearer (though there's logic in there for handling integer tokens), thoughts?
There was a problem hiding this comment.
Maybe let's add a comment explaining that we use word instead of number to avoid that additional logic?
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 84fb9a1:
|
There was a problem hiding this comment.
I think we could add a compact: true test runner for @babel/generator, like we did for estree in @babel/parser. Essentially we shall enforce the following idempotent invariance:
generate(ast, { compact: true }) === generate(parse(generate(ast, { compact: true })), { compact: true })
|
@JLHwung yeah been thinking of doing this for a while, will take a look |
existentialism
changed the title
github-actions
bot
added
the
outdated
