Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid line breaks between class members head and key #12653

Merged
merged 1 commit into from Jan 24, 2021

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jan 18, 2021

Q                       A
Fixed Issues? Fixes #12606
Patch: Bug Fix? Y
License MIT

In this PR we insert line breaks between decorators and potential modifiers/set/get/async, so that they will be printed within the same line of member key start.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: generator labels Jan 18, 2021
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/37725/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0e9bf54:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo changed the title fix: avoid line breaks between member heads and member key fix: avoid line breaks between class members head and key Jan 24, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit 446c70c into babel:main Jan 24, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the fix-12606 branch January 24, 2021 01:06
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 25, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[babel-generator] not work with retainLines: true
4 participants