Define class elements in the correct order #12723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/39267/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8c755f3:
|
existentialism
approved these changes
Feb 1, 2021
JLHwung
reviewed
Feb 1, 2021
| let descriptor; | ||
| if ( | ||
| !methods.hasComputed && | ||
| t.isStringLiteral(key) && |
There was a problem hiding this comment.
Not related to this PR, but we should also merge descriptors for NumericLiteral.
class C {
set 0n(v) {}
get 0n() {}
set 1(v) {}
get 1() {}
}There was a problem hiding this comment.
This code is new, so I can handle it here (they are merged with main).
JLHwung
reviewed
Feb 1, 2021
packages/babel-plugin-transform-classes/test/fixtures/spec/computed-methods/output.js
Show resolved
Hide resolved
nicolo-ribaudo
commented
Feb 1, 2021
| // infer function name | ||
| if (node.kind === "method") { | ||
| fn = nameFunction({ id: key, node: node, scope }); | ||
| } |
There was a problem hiding this comment.
We can also infer the name of getters and setters, but I'll do that in a separate PR since it's not strictly related to this one.
JLHwung
approved these changes
Feb 2, 2021
This was referenced Mar 8, 2021
chore(deps-dev): bump @babel/plugin-external-helpers from 7.10.4 to 7.12.13
chantouchsek/v-timers#12
Closed
Closed
This was referenced Mar 15, 2021
Closed
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few bugs with class elements coalescing: