Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support destructuring variable declarator within TS namespace #12760

Merged
merged 4 commits into from Feb 5, 2021

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Feb 5, 2021

Q                       A
Fixed Issues? Fixes #11461
Patch: Bug Fix? Y
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This PR should be reviewed by commits. It supports general declarator via t.getBindingIdentifiers. The following snippet

namespace Foo
{
    export const {a, b} = obj
}

is now transformed to

let Foo;

(function (_Foo) {
  const {a, b} = obj;
  _Foo.a = a, _Foo.b = b;
})(Foo || (Foo = {}));

Unlike TypeScript which also transpiles patterns even if we target to ESNext, Babel does not transpile and instead it will delegate to @babel/plugin-transform-destructuring for further transpilation if required.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: typescript labels Feb 5, 2021
const M1 = {}
export module M1 {}
const { M2 } = {}
export module M2 {}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Babel currently throws for

const { M2 } = {}
export module M2 {}

because M2 is never added to names, and TSModuleDeclaration handler will add M2 variable declarations which collide with const { M2 } = {}.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0079773:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Feb 5, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/39704/

nicolo-ribaudo
nicolo-ribaudo previously approved these changes Feb 5, 2021
@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Feb 5, 2021

Wait, approved too early

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Feb 5, 2021

The CI error is related

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Destructuring assignment not supported in namespaces
4 participants