Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support noDocumentAll for obj?.#p #12762

Merged
merged 1 commit into from Feb 5, 2021
Merged

Support noDocumentAll for obj?.#p #12762

merged 1 commit into from Feb 5, 2021

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Feb 5, 2021

Q                       A
Minor: New Feature? Y
Tests Added + Pass? Y
License MIT

This PR depends on #12470. Babel now respects noDocumentAll when transforming obj?.#p. I marked this PR as Output optimization as noDocumentAll has been implemented in #12481.

@JLHwung JLHwung added PR: Output optimization 🔬 A type of pull request used for our changelog categories area: assumptions labels Feb 5, 2021
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/39711/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4cf9bcc:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung JLHwung mentioned this pull request Feb 5, 2021
Merged
24 tasks
nicolo-ribaudo
nicolo-ribaudo approved these changes Feb 5, 2021
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@JLHwung JLHwung merged commit 7d9f061 into babel:feat-7.13.0/babel-core-features Feb 5, 2021
@JLHwung JLHwung deleted the noDocumentAllFor？．＃ branch February 5, 2021 19:27
nicolo-ribaudo pushed a commit to nicolo-ribaudo/babel that referenced this pull request Feb 10, 2021
@JLHwung @nicolo-ribaudo
optimās: respect noDocumentAll when transforming obj?.#p (babel#12762)
a081c2a
nicolo-ribaudo pushed a commit to nicolo-ribaudo/babel that referenced this pull request Feb 11, 2021
@JLHwung @nicolo-ribaudo
optimās: respect noDocumentAll when transforming obj?.#p (babel#12762)
3630b02
nicolo-ribaudo pushed a commit that referenced this pull request Feb 16, 2021
@JLHwung @nicolo-ribaudo
Optimās: respect noDocumentAll when transforming obj?.#p (#12762)
0b1b012
nicolo-ribaudo pushed a commit that referenced this pull request Feb 16, 2021
@JLHwung @nicolo-ribaudo
Optimās: respect noDocumentAll when transforming obj?.#p (#12762)
e7944a5
nicolo-ribaudo pushed a commit that referenced this pull request Feb 21, 2021
@JLHwung @nicolo-ribaudo
Optimās: respect noDocumentAll when transforming obj?.#p (#12762)
33fbf84
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jridgewell jridgewell jridgewell approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
area: assumptions outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Output optimization 🔬 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JLHwung @babel-bot @jridgewell @nicolo-ribaudo