Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babel-parser(ts): Throw recoverable for duplicates access modifier #12775

Merged
merged 3 commits into from Feb 9, 2021
Merged

babel-parser(ts): Throw recoverable for duplicates access modifier #12775

merged 3 commits into from Feb 9, 2021

Conversation

sosukesuzuki
Copy link
Member

Q                       A
Fixed Issues? Fixes #12774
Patch: Bug Fix? Y
Tests Added + Pass? Yes
License MIT

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 6, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 61b3e1f:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Feb 6, 2021 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/39904/

@sosukesuzuki sosukesuzuki added area: errors area: typescript pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Feb 6, 2021
JLHwung
JLHwung approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some typing nits.

packages/babel-parser/src/plugins/typescript/index.js Outdated Show resolved Hide resolved
packages/babel-parser/src/plugins/typescript/index.js Outdated Show resolved Hide resolved
packages/babel-parser/src/plugins/typescript/index.js Outdated Show resolved Hide resolved
@nicolo-ribaudo nicolo-ribaudo merged commit f1a3275 into babel:main Feb 9, 2021
@sosukesuzuki sosukesuzuki mentioned this pull request Feb 19, 2021
Merged
14 tasks
This was referenced Mar 11, 2021
Closed
Open
@dependabot dependabot bot mentioned this pull request Mar 18, 2021
Closed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 12, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
@sosukesuzuki sosukesuzuki deleted the fix-12774 branch June 15, 2021 14:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@JLHwung JLHwung JLHwung approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees
No one assigned
Labels
area: errors area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

babel-parser(ts): Unfriendly error for duplicates access modifier
6 participants
@sosukesuzuki @babel-bot @existentialism @JLHwung @kaicataldo @nicolo-ribaudo