test: avoid deprecated jest.addMatchers #12811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a5eaa77:
|
nicolo-ribaudo
added
area: tests
PR: Internal 🏠
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/40678/ |
SimenB
reviewed
Feb 18, 2021
| pass, | ||
| message: pass | ||
| ? () => { | ||
| throw new Error(".toEqualFile does not support negation"); |
There was a problem hiding this comment.
can check this.isNot and throw earlier. doesn't matter in practice I guess
SimenB
reviewed
Feb 18, 2021
| @@ -377,7 +376,7 @@ export default function ( | |||
| if (suiteOpts.ignoreSuites?.includes(testSuite.title)) continue; | |||
|
|
|||
| describe(name + "/" + testSuite.title, function () { | |||
| jest.addMatchers({ | |||
| expect.extend({ | |||
There was a problem hiding this comment.
sorta weird to extend inside the describe and not at the top level
SimenB
reviewed
Feb 18, 2021
| throw new Error(".toEqualFile does not support negation"); | ||
| } | ||
| : () => { | ||
| const diffString = diff(code, actual, { |
There was a problem hiding this comment.
this uses an imported jest-diff, can just do this.utils.diff instead and not have to have a dependency on jest-diff
This was referenced Mar 11, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jest.addMatchershas been deprecated for ...umm, idk how long, I only recently learned it exists 😂... and is being removed in Jest 27.Changing this now means you won't be scared by a hundred failing tests when upgrading (although there may of course be other breaking changes affecting you).