Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babel-register: Don’t rewrite the cache if it’s not dirty #12813

Merged
merged 1 commit into from Feb 18, 2021
Merged

babel-register: Don’t rewrite the cache if it’s not dirty #12813

merged 1 commit into from Feb 18, 2021

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Feb 17, 2021

Q A
Fixed Issues? N/A
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link N/A
Any Dependency Changes? No
License MIT

Fix @babel/register not to rewrite the cache if it’s not dirty. This saves time and avoids unnecessary SSD wear.

@babel-bot
Copy link
Collaborator

babel-bot commented Feb 17, 2021 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/40785/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 17, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0555576:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@andersk
babel-register: Don’t rewrite the cache if it’s not dirty
0555576 
This saves time and avoids unnecessary SSD wear.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
JLHwung
JLHwung approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JLHwung JLHwung added pkg: register PR: Polish 💅 A type of pull request used for our changelog categories labels Feb 18, 2021
nicolo-ribaudo
nicolo-ribaudo reviewed Feb 18, 2021
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit a940c09 into babel:main Feb 18, 2021
@nicolo-ribaudo nicolo-ribaudo added PR: Performance 🏃‍♀️ A type of pull request used for our changelog categories and removed PR: Polish 💅 A type of pull request used for our changelog categories labels Feb 18, 2021
@merceyz merceyz mentioned this pull request May 20, 2021
Merged
3 tasks
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo left review comments

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: register PR: Performance 🏃‍♀️ A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andersk @babel-bot @JLHwung @nicolo-ribaudo