Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create IPC channel for spawned babel-node process #12836

Merged
merged 1 commit into from Feb 21, 2021

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Feb 20, 2021

Q                       A
Fixed Issues? Fixes #4554
Patch: Bug Fix? Y
Tests Added + Pass? Yes
License MIT

Per options.stdio docs, providing "ipc" as the fourth stdio file descriptor will instruct Node.js to create an IPC channel for sub process so that process.send and process.disconnect() is enabled.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: node labels Feb 20, 2021
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 75d79eb:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/41217/

@nicolo-ribaudo nicolo-ribaudo merged commit 74dc70a into babel:main Feb 21, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the fix-4554 branch February 21, 2021 18:31
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 24, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: node PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

process.send is not a function in child spawned with babel-node (ipc doesn't work)
4 participants