Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check descriptor before private field access #12910

Merged
merged 2 commits into from Mar 3, 2021
Merged

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Feb 25, 2021

Q                       A
Fixed Issues? Fixes #12904
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

As suggested in #12904, check if descriptor is undefined before pass it as a descriptor. Note that the privateFieldAsProperty a.k.a. loose handler is not affected because the loosePrivateKey is always hoisted before class declaration. So in this case they will throw the same error as if we are accessing a private properties that is not defined in current class.

I mark this PR as polish because we still throw on the new cases, but the error message is confusing. This PR is now based on #12911, please review that PR first.

@JLHwung JLHwung added PR: Polish 💅 A type of pull request used for our changelog categories area: errors labels Feb 25, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 25, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f9123cf:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

C.#p;
}
}
}).toThrow(/attempted to use private field on non-instance/);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly #12905, the Babel behaviour on static accessors are not aligned with V8. I will try to tackle in a separate PR. Before that it is just a test case parallel to properties.

@babel-bot
Copy link
Collaborator

babel-bot commented Feb 25, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/43564/

This was referenced Mar 17, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: errors outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories Spec: Class Fields
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing error when static private field is accessed before declaration.
4 participants