New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure static private method init run before static property #12918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
Spec: Private Methods
labels
Feb 26, 2021
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/43651/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4ca3404:
|
JLHwung
force-pushed
the
fix-12905
branch
3 times, most recently
from
March 3, 2021 20:16
e04868e
to
9336747
Compare
Per 15.7.12 Runtime Semantics: ClassDefinitionEvaluation, when DefineField is invoked, the class binding used in field initializer will have a receiver F, which has all static methods defined but may still have uninvoked initializer due to the order of DefineField executions on staticFields. Therefore, we place static class methods definition before static field.
nicolo-ribaudo
approved these changes
Mar 3, 2021
jridgewell
approved these changes
Mar 3, 2021
This was referenced Mar 8, 2021
Merged
Merged
This was referenced Mar 17, 2021
Closed
Closed
Merged
github-actions
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
Jun 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
Spec: Private Methods
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #12917, please review that one first.
As suggested in #12905, this PR places private methods before private static properties, see also the commit message for the rationale.
For example, the following snippet
currently transforms to
in this PR transforms to
where
_m
is placed before_p
, so when_p.value
is evaluated, the static method descriptor_m
will have been defined.