Avoid using CJS globals in internal source files #12963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
the
PR: Internal 🏠
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/43946/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 44bd672:
|
nicolo-ribaudo
force-pushed
the
internal-remove-cjs-globals
branch
from
b86a6b9
to
3f7ea3a
Compare
nicolo-ribaudo
commented
Mar 4, 2021
codemods/babel-plugin-codemod-object-assign-to-object-spread/test/index.js
Outdated
Show resolved
Hide resolved
nicolo-ribaudo
force-pushed
the
internal-remove-cjs-globals
branch
9 times, most recently
from
6dced96
to
b8b8f78
Compare
nicolo-ribaudo
force-pushed
the
internal-remove-cjs-globals
branch
3 times, most recently
from
a7cb42f
to
ba8d8e0
Compare
This was referenced Mar 17, 2021
Closed
Closed
Merged
4 tasks
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #12795
After this PR our sources are almost ESM-ready, the only remaining big change is that
importstatements should use the explicit extension.