Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: raise SyntaxError for declare before getter/setter #13143

Merged
merged 2 commits into from Apr 17, 2021

Conversation

fedeci
Copy link
Member

@fedeci fedeci commented Apr 13, 2021

Q                       A
Fixed Issues? Fixes #13126
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

We check if method is both a getter/setter and declare in pushClassMethod so that class properties are excluded from the test.

@babel-bot
Copy link
Collaborator

babel-bot commented Apr 13, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45357/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 13, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2055132:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@JLHwung JLHwung added area: typescript pkg: parser PR: Spec Compliance 👓 A type of pull request used for our changelog categories labels Apr 13, 2021
@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser PR: Spec Compliance 👓 A type of pull request used for our changelog categories and removed PR: Spec Compliance 👓 A type of pull request used for our changelog categories pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Apr 13, 2021
@nicolo-ribaudo
Copy link
Member

^ Nice, a labels race condition 😄

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit 368bf89 into babel:main Apr 17, 2021
@fedeci fedeci deleted the declare-accessors branch April 17, 2021 21:06
fisker added a commit to prettier/prettier that referenced this pull request Apr 25, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Spec Compliance 👓 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Babel parser typescript should throw when declare is applied to accessors
4 participants