Fix const violations in ESM imports when transformed to CJS

[overlookmotel]

Q	A
Fixed Issues?	No issue filed
Patch: Bug Fix?	Yes
Major: Breaking Change?	No
Minor: New Feature?	No
Tests Added + Pass?	Yes
Documentation PR Link	n/a
Any Dependency Changes?	No
License	MIT

This PR fixes similar cases to #13248 in plugin-transform-modules-commonjs relating to const violations with import statements.

e.g.:

import x from 'foo';
x = 1;

This PR:

1. Fixes compilation error if import x from 'foo'; x &&= 1;
2. Adds const violation errors for import x from 'foo'; for ( x in {} ) {}
3. Fixes a small bug with for loops without a block statement e.g. export let x = 1; for ( x in {} ) x();
4. Adds more tests for assignments

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f76a694:

Sandbox	Source
babel-repl-custom-plugin	Configuration
babel-plugin-multi-config	Configuration

[JLHwung]

Should we record all const violation names? e.g.

import { x, y } from 'foo';
for ( [x, y] of [] );

[nicolo-ribaudo]

It's enough to report the first one, since we only inject the error for the first one (the others are not observable anyway).

[overlookmotel]

I think @nicolo-ribaudo is correct. Only the first is necessary as that will throw an error before the 2nd is evaluated.

[overlookmotel]

@JLHwung @nicolo-ribaudo Thanks for the comments. Just to let you know, I'm flat out next few weeks, so will have to leave this until my project is done. But I'll come back to this and make the changes requested next month.

[overlookmotel]

@JLHwung Changes requested have been made. I think this is ready to merge if you're happy with it.

[JLHwung]

Thanks!

[overlookmotel]

Thanks very much for swift merge.