Pass assumptions set in presets to plugins #13321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46185/ |
|
Thank you for the quick fix, @nicolo-ribaudo! ❤️ (The |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f1ab26e:
|
fedeci
approved these changes
May 17, 2021
JLHwung
approved these changes
May 17, 2021
| @@ -68,10 +68,9 @@ export default gensync<(inputOpts: unknown) => ResolvedConfig | null>( | |||
| throw new Error("Assertion failure - plugins and presets exist"); | |||
| } | |||
|
|
|||
| const pluginContext: Context.FullPlugin = { | |||
| const presetContext: Context.FullPreset = { | |||
There was a problem hiding this comment.
Will presetContext.assumptions be undefined?
There was a problem hiding this comment.
Yes, but it doesn't matter because the preset API doesn't have a method to read assumptions anyway.
existentialism
approved these changes
May 17, 2021
This was referenced May 26, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that we where building the plugin API context using
assumptionscoming from the config options, completely ignoring theassumptionsset by presets.