Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for d flag of regex literals in parser #13396

Merged
merged 1 commit into from May 31, 2021

Conversation

ota-meshi
Copy link
Contributor

@ota-meshi ota-meshi commented May 29, 2021

Q                       A
Fixed Issues? Fixes #13393
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? 👍
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT

This PR changes the parser to accept the d flag of the regular expression literal.

https://github.com/tc39/proposals/blob/master/finished-proposals.md
tc39/proposals@f0adbe1
https://github.com/tc39/proposal-regexp-match-indices
tc39/ecma262#1713

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46551/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7762a71:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo added pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels May 30, 2021
@JLHwung JLHwung merged commit 0b29b5c into babel:main May 31, 2021
@ota-meshi ota-meshi deleted the d-flag branch May 31, 2021 12:52
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 31, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the parser to allow the RegExp d flag.
4 participants